Skip to content

[cxx-interop] Add CxxShim library; move __swift_interopStaticCast into it.#59754

Merged
zoecarver merged 2 commits intoswiftlang:mainfrom
zoecarver:fix-static-down-cast-shim
Jul 6, 2022
Merged

[cxx-interop] Add CxxShim library; move __swift_interopStaticCast into it.#59754
zoecarver merged 2 commits intoswiftlang:mainfrom
zoecarver:fix-static-down-cast-shim

Conversation

@zoecarver
Copy link
Copy Markdown
Contributor

No description provided.

@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Jun 28, 2022
@zoecarver zoecarver requested a review from egorzhdan June 28, 2022 18:30
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this a diagnostic in a follow-up patch.

Copy link
Copy Markdown
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have some rebasing to do since I merged #59747 before you sent this patch 😈

LGTM except for one CMake issue.

@zoecarver zoecarver force-pushed the fix-static-down-cast-shim branch from 30a9353 to bbc2007 Compare June 28, 2022 18:48
@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

1 similar comment
@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test macOS

@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test Windows

@zoecarver zoecarver force-pushed the fix-static-down-cast-shim branch 2 times, most recently from f21f821 to 800bd74 Compare June 30, 2022 20:44
@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not used anymore, it can be removed.

@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test windows

@zoecarver zoecarver force-pushed the fix-static-down-cast-shim branch from 800bd74 to 273065e Compare July 5, 2022 23:06
@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

@zoecarver zoecarver force-pushed the fix-static-down-cast-shim branch from 273065e to 8cf4d3b Compare July 6, 2022 03:03
@zoecarver
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ interop Feature: Interoperability with C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants