[runtime] Add platform independent version of dladdr() / Dl_info#5969
Merged
jckarter merged 1 commit intoswiftlang:masterfrom Nov 29, 2016
Merged
[runtime] Add platform independent version of dladdr() / Dl_info#5969jckarter merged 1 commit intoswiftlang:masterfrom
jckarter merged 1 commit intoswiftlang:masterfrom
Conversation
- Win32 does not support dlfcn.h, Dl_info or dladdr() so add lookupSymbol() as a wrapper for ELF/MachO/Win32 - Win32 version needs an implementation, currently it just returns an error for `cannot lookup address'
Contributor
|
Yeah, this makes sense to me. |
Contributor
|
@swift-ci Please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent merging of #5944 which adds some fixes for building on windows, and a need to make #5394 not break those changes this PR moves the use of dladdr() and Dl_info into the platform specific implementation files and adds an empty function for Win32.
Currently only tested on Linux and macOS, the Win32 version has not been compile tested. This PR is making the assumption that Win32 doesnt support Dl_info/dladdr(). If that is not the case then it may not be needed.
Win32 does not support dlfcn.h, Dl_info or dladdr() so add
lookupSymbol() as a wrapper for ELF/MachO/Win32
Win32 version needs an implementation, currently it just returns
an error for `cannot lookup address'