[SwiftShims] Make the void* arguments of memcmp nullable#36666
Merged
xymus merged 2 commits intoswiftlang:mainfrom Apr 5, 2021
Merged
[SwiftShims] Make the void* arguments of memcmp nullable#36666xymus merged 2 commits intoswiftlang:mainfrom
xymus merged 2 commits intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci Please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test macOS |
Contributor
Author
|
On Linux we're getting the opposite error now: instead of the previous error on macOS: (The error format changed since then and I'm there's a problem in it.) |
Contributor
Author
|
@swift-ci Please smoke test |
beccadax
approved these changes
Apr 1, 2021
Contributor
|
@swift-ci please smoke test |
This should correspond to the definition of memcmp in usr/include/string.h and keep it from being a source of confusion for the compiler. rdar://69876253
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
The libs compiled fine under Linux this time but the test failed. @swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci Please smoke test macOS |
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should correspond to the definition of
memcmpinusr/include/string.hand keep it from being a source of confusion for the compiler.rdar://69876253