Skip to content

Use SWIFT_HOST_VARIANT_ARCH for SWIFT_PRIMARY_VARIANT_ARCH_default instead of x86_64#35231

Closed
davidungar wants to merge 1 commit intoswiftlang:mainfrom
davidungar:build-on-m1
Closed

Use SWIFT_HOST_VARIANT_ARCH for SWIFT_PRIMARY_VARIANT_ARCH_default instead of x86_64#35231
davidungar wants to merge 1 commit intoswiftlang:mainfrom
davidungar:build-on-m1

Conversation

@davidungar
Copy link
Copy Markdown
Contributor

Building Swift failed on my m1 MBP:

./swift/utils/build-script --release --no-assertions --skip-build-benchmarks --swift-darwin-supported-archs arm64

The following was created in build/Ninja-DebugAssert/swift-macosx-arm64/build.ninja

# Phony custom command for stdlib/CMakeFiles/swift-test-stdlib

build stdlib/CMakeFiles/swift-test-stdlib: phony stdlib/swift-test-stdlib-macosx-x86_64

This change fixes it.

@davidungar davidungar requested a review from xedin December 27, 2020 20:50
@davidungar
Copy link
Copy Markdown
Contributor Author

@swift-ci please test

@finagolfin
Copy link
Copy Markdown
Member

There's already a pull submitted for this, #34998, though it uses a different variable than this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants