[CMake] Simplify two binary variables into one tri-state variable#32042
[CMake] Simplify two binary variables into one tri-state variable#32042davezarzycki merged 1 commit intoswiftlang:masterfrom
Conversation
|
@swift-ci please test |
compnerd
left a comment
There was a problem hiding this comment.
Making the Swift build system more similar to the LLVM options is definitely a good idea.
There was a problem hiding this comment.
I think that we should simplify this like the previous case in cmake/modules/AddSwift.cmake
drodriguez
left a comment
There was a problem hiding this comment.
The parts that I know (the Android parts, mostly), looks fine to me. Should be functionally equivalent to the existing code. There's only that one point that should be double checked. Otherwise looks good.
There was a problem hiding this comment.
I think the manipulations around these lines (L418-L422) are the same to the ones in AddSwiftUnittests.cmake, but the modifications are different: some checks are kept here, while they are drop in the other file. Is the divergence intentional?
|
Build failed |
Also remove some ancient logic to detect and ignore requests to use LLD. If people want to explicitly use LLD, they probably have a reason and we shouldn't second guess them.
|
Hi @compnerd and @drodriguez – I've simplified AddSwiftStdlib.cmake more. I think we should make @swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please clean test linux |
|
Yeah, I agree on the idea that if the user specified it, we assume correct and honor it. |
|
@swift-ci please test windows |
Also remove some ancient logic to detect and ignore requests to use LLD. If people want to explicitly use LLD, they probably have a reason and we shouldn't second guess them.