build: shuffle add_swift_target_library (NFC)#29807
build: shuffle add_swift_target_library (NFC)#29807compnerd merged 1 commit intoswiftlang:masterfrom
add_swift_target_library (NFC)#29807Conversation
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
Does this handle the swiftSwiftLang library? I am pretty sure that still uses this. That being said when I last hit this, I spoke with @harlanhaskins and he said that we can move that into a swiftpm based package build. Then this is good to go. |
|
Interesting, Im definitely in favour of moving swiftSwiftLang into a swiftpm package. That said, that will continue to work after this change, its just a code movement to shuffle the target specific logic into the target subdirectory. |
|
That concern has been alleviated. For the time being |
671eb81 to
711e84a
Compare
|
@swift-ci please clean test |
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
|
Build failed |
711e84a to
f96bfee
Compare
|
@swift-ci please clean test |
|
Build failed |
|
Build failed |
f96bfee to
2e41360
Compare
|
@swift-ci please clean test |
This is a purely code motion change. It moves the functions that are specific to `SwiftSource.cmake` into `SwiftSource.cmake`. Target functions are moved to `stdlib/cmake/modules/AddSwiftStdlib.cmake`.
2e41360 to
fc67fc7
Compare
|
@swift-ci please clean test |
|
@compnerd This breaks the change you did from two weeks ago: 379137f6f1. |
This moves the
add_swift_target_libraryinto the stdlib level cmakemodule directory. This is used strictly for building the standard
library bits.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.