[CMake] Fix the static bindings workflow.#27814
Merged
JDevlieghere merged 1 commit intoswiftlang:masterfrom Oct 24, 2019
Merged
[CMake] Fix the static bindings workflow.#27814JDevlieghere merged 1 commit intoswiftlang:masterfrom
JDevlieghere merged 1 commit intoswiftlang:masterfrom
Conversation
Rename LLDB_ALLOW_STATIC_BINDINGS to LLDB_USE_STATIC_BINDINGS and make LLDB use the static bindings unconditionally when it's set. The current variable is opaque because it allows LLDB to use the static bindings, but only if SWIG is not found. If an incompatible version of swig is found, it reports a fatal error. This serves no purpose other than to confuse the user. The corresponding LLDB patch simplifies things and makes the variable do what you expect. When enabled, LLDB uses the static bindings. When disabled, we try to generate them with SWIG. This patch modifies the build scripts to pass the new variable.
Contributor
Author
|
@swift-ci test with swiftlang/llvm-project#13 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename LLDB_ALLOW_STATIC_BINDINGS to LLDB_USE_STATIC_BINDINGS and make
LLDB use the static bindings unconditionally when it's set. The current
variable is opaque because it allows LLDB to use the static bindings,
but only if SWIG is not found. If an incompatible version of swig is
found, it reports a fatal error. This serves no purpose other than to
confuse the user.
The corresponding LLDB patch simplifies things and makes the variable do
what you expect. When enabled, LLDB uses the static bindings. When
disabled, we try to generate them with SWIG.
This patch modifies the build scripts to pass the new variable.