IRGen/Runtime: Relative-reference the nominal type descriptor and parent type from metadata.#1154
Closed
jckarter wants to merge 2 commits intoswiftlang:masterfrom
Closed
IRGen/Runtime: Relative-reference the nominal type descriptor and parent type from metadata.#1154jckarter wants to merge 2 commits intoswiftlang:masterfrom
jckarter wants to merge 2 commits intoswiftlang:masterfrom
Conversation
Contributor
Author
|
This is awaiting matching work from @egranata in lldb to handle the format change. |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
In #1157 it was noted that |
Contributor
|
I'll try to get to it this week |
This prevents the linker from trying to emit relative relocations to locally-defined public symbols into dynamic libraries, which gives ld.so heartache.
…ent type from metadata. Save a couple relocations per concrete value type, leaving only the value witness table as an absolute symbol.
abc36a3 to
1306d40
Compare
Contributor
Author
|
@egranata Any progress? |
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Not yet, sorry - other work has kept me busy all week - and the stable merge seems to have left us in a rather brittle state, so I am hesitant to push changes until that is taken care of. Do you have a deadline to get this in by? |
Contributor
Author
|
No worries, thanks for the update @egranata. There's no deadline—just the occasion frustration of merge hell keeping the branch alive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save a couple relocations per concrete value type, leaving only the value witness table as an absolute symbol.