[CMake][lldb] change the runpath to an architecture-specific directory on ELF platforms#6383
Closed
finagolfin wants to merge 1 commit intoswiftlang:stable/20221013from
Closed
[CMake][lldb] change the runpath to an architecture-specific directory on ELF platforms#6383finagolfin wants to merge 1 commit intoswiftlang:stable/20221013from
finagolfin wants to merge 1 commit intoswiftlang:stable/20221013from
Conversation
…y on ELF platforms This is needed for swiftlang/swift#63782, which changes the Unix toolchain to look for libraries in architecture-specific directories.
Member
Author
|
@eeckstein, you added some of this code I'm modifying. Now that this passed the CI on the linked compiler pull, looking for review so I can get this in before the upcoming 5.9 branch. Please don't merge though, as all 11 pulls will have to be merged together. |
eeckstein
approved these changes
Mar 8, 2023
eeckstein
left a comment
There was a problem hiding this comment.
If it passes CI, I guess the change is okay.
Member
Author
|
Closing since the Swift devs want to take a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for swiftlang/swift#63782, which changes the Unix toolchain to look for libraries in architecture-specific directories.