cherry picks to Stable/20221013 #4#5906
Merged
ziqingluo-90 merged 12 commits intoswiftlang:stable/20221013from Jan 12, 2023
Merged
cherry picks to Stable/20221013 #4#5906ziqingluo-90 merged 12 commits intoswiftlang:stable/20221013from
ziqingluo-90 merged 12 commits intoswiftlang:stable/20221013from
Conversation
…decls in modernize-use-nullptr The check has produced false positives when checking the default implementation of the spaceship operator. The default implementation should be skipped by the check. Modified the existing test so that the check runs into the bug without this fix and add another test case. Fixes llvm#53961. Patch by Jens Massberg. Reviewed By: ilya-biryukov Differential Revision: https://reviews.llvm.org/D138701 (cherry picked from commit db335d0)
Note that std::optional does not offer create(). This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 (cherry picked from commit 20ba079)
(cherry picked from commit dbb94b4)
(cherry picked from commit b6a73d0)
Differential Revision: https://reviews.llvm.org/D137340 (cherry picked from commit 65d6d67)
This patch mechanically replaces None with std::nullopt where the compiler would warn if None were deprecated. The intent is to reduce the amount of manual work required in migrating from Optional to std::optional. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 (cherry picked from commit 1806006)
This patch mechanically replaces None with std::nullopt where the compiler would warn if None were deprecated. The intent is to reduce the amount of manual work required in migrating from Optional to std::optional. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 (cherry picked from commit 34e0d05)
This patch mechanically replaces None with std::nullopt where the compiler would warn if None were deprecated. The intent is to reduce the amount of manual work required in migrating from Optional to std::optional. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 (cherry picked from commit cd8702e)
This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 (cherry picked from commit 2402c46)
This patch adds interpretation of the overloaded equality and inequality operators available for the optional types. Fixes issue llvm#57253. Differential Revision: https://reviews.llvm.org/D139360 (cherry picked from commit 390029b)
This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 (cherry picked from commit aee5910)
…-namespace The same functionality is already implemented in the readability-static-definition-in-anonymous-namespace check, including automatic fixes. Differential Revision: https://reviews.llvm.org/D139197 (cherry picked from commit 7fd8387)
e36cf9e to
724795d
Compare
Author
|
I removed |
|
Wait a sec, I don't see any |
|
Yeah indeed, I tried it manually and I'm getting errors on this branch: Did these cherry-picks compile locally for you? I suspect that they rely on another patch that bumps the C++ standard version in CMake configs, and we probably don't have the authority to cherry-pick them. |
|
Never mind, I looked at the wrong branch. This compiles perfectly, please merge! |
Author
Thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.