[lldb] Look through existential types when handling typealiases in SwiftASTContext to correctly handle AnyObject existentials.#4852
Closed
hborla wants to merge 1 commit intoswiftlang:stable/20211026from
Conversation
SwiftASTContext to correctly handle AnyObject existentials.
Member
Author
|
@swift-ci please test |
adrian-prantl
requested changes
Jun 18, 2022
adrian-prantl
left a comment
There was a problem hiding this comment.
Sorry — just realized that this PR is on the wrong branch.
The Swift release/5.7 branch goes with llvm-project swift/release/5.7. Any commit there also needs to be (manually) cherrypicked to stable/20220421 and to next. You can push these cherry-picks without testing.
Member
Author
|
@adrian-prantl whoops, I'll get that fixed now, thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#41909 updates the representation of
AnyandAnyObjectin the Swift frontend to useExistentialType. Typealiases likeAnyObjectcan be used as existential types, which are represented asExistentialType(TypeAliasType), so LLDB should look through to an existential type's constraint when checking whether it has a typealias.