[lldb][swift] Add missing swiftTest decorators#1922
Merged
Teemperor merged 1 commit intoswiftlang:swift/mainfrom Oct 9, 2020
Merged
[lldb][swift] Add missing swiftTest decorators#1922Teemperor merged 1 commit intoswiftlang:swift/mainfrom
Teemperor merged 1 commit intoswiftlang:swift/mainfrom
Conversation
The swiftTest decorator should be on all Swift tests to make sure they are only run in configurations where Swift is supported. Otherwise these tests are still run and will fail when the Swift plugin is disabled.
Author
|
@swift-ci test |
kastiglione
approved these changes
Oct 8, 2020
adrian-prantl
approved these changes
Oct 8, 2020
Author
|
@swift-ci test lldbuild tests failed... |
|
@swift-ci test macOS Platform |
Author
|
Hmm, the failing test isn't one of the ones I modified. |
Author
|
@swift-ci test macOS Platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swiftTest decorator should be on all Swift tests to make sure they are only
run in configurations where Swift is supported. Otherwise these tests are still
run and will fail when the Swift plugin is disabled.