[dwarfdump] Warn for tags with DW_CHILDREN_yes but no children.#1867
Merged
JDevlieghere merged 2 commits intoswiftlang:apple/stable/20200714from Oct 7, 2020
JDevlieghere:🍒/bastille/e1ef7183c6f008fa13cbe273500b020c4fad1252
Hidden character warning
The head ref may contain hidden characters: "\ud83c\udf52/bastille/e1ef7183c6f008fa13cbe273500b020c4fad1252"
Merged
[dwarfdump] Warn for tags with DW_CHILDREN_yes but no children.#1867JDevlieghere merged 2 commits intoswiftlang:apple/stable/20200714from JDevlieghere:🍒/bastille/e1ef7183c6f008fa13cbe273500b020c4fad1252
JDevlieghere merged 2 commits intoswiftlang:apple/stable/20200714from
JDevlieghere:🍒/bastille/e1ef7183c6f008fa13cbe273500b020c4fad1252
Conversation
Flag DIEs that have DW_CHILDREN_yes set in their abbreviation but don't actually have any children. rdar://59809554 Differential revision: https://reviews.llvm.org/D88048 (cherry picked from commit e1ef718)
Author
|
@swift-ci please test |
This test relies on functionality in obj2yaml that's not present on the stable branch. I made an attempt at backporting all the necessary changes but quickly realized it was too much churn for this change.
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag DIEs that have DW_CHILDREN_yes set in their abbreviation but don't
actually have any children.
rdar://59809554
Differential revision: https://reviews.llvm.org/D88048
(cherry picked from commit e1ef718)