build: correct MSVC and Windows mixup for CLANG_BUILD_STATIC (#18…#12469
Merged
compnerd merged 1 commit intoswiftlang:stable/21.xfrom Feb 27, 2026
Merged
build: correct MSVC and Windows mixup for CLANG_BUILD_STATIC (#18…#12469compnerd merged 1 commit intoswiftlang:stable/21.xfrom
MSVC and Windows mixup for CLANG_BUILD_STATIC (#18…#12469compnerd merged 1 commit intoswiftlang:stable/21.xfrom
Conversation
…m#183609) The build incorrectly used `MSVC` to determine that we were building for Windows (MS ABI). This prevents the use of the GNU driver for building LLVM for Windows. Adjust the condition to `WIN32 AND NOT MINGW` to correctly identify that we are building for Windows MS ABI. (cherry picked from commit 20ec9a9)
Member
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…3609)
The build incorrectly used
MSVCto determine that we were building for Windows (MS ABI). This prevents the use of the GNU driver for building LLVM for Windows. Adjust the condition toWIN32 AND NOT MINGWto correctly identify that we are building for Windows MS ABI.(cherry picked from commit 20ec9a9)