Add support on sfcolor when using sfimage#370
Merged
melonamin merged 1 commit intoswiftbar:mainfrom Apr 8, 2023
Merged
Conversation
Always uses the first defined sfcolor (if there is one) to color the SF Symbol.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always uses the first defined
sfcolor(if there is one) to color thesfimagedefined SF Symbol. On macOS 13 also forces the monochrome representation.Current caveat: The first
sfcoloris not consumed and would be used equally for the first appearing SF Symbol in the text representation. I can add proper handling for that as well if desired.