Skip to content

[AHC Transport] Async bodies + swift-http-types adoption#16

Merged
czechboy0 merged 10 commits intoswift-server:mainfrom
czechboy0:hd-adopt-http-types
Sep 27, 2023
Merged

[AHC Transport] Async bodies + swift-http-types adoption#16
czechboy0 merged 10 commits intoswift-server:mainfrom
czechboy0:hd-adopt-http-types

Conversation

@czechboy0
Copy link
Copy Markdown
Collaborator

@czechboy0 czechboy0 commented Sep 7, 2023

Motivation

AHC transport changes of the approved proposals apple/swift-openapi-generator#255 and apple/swift-openapi-generator#254.

Modifications

  • Adapts to the runtime changes, depends on HTTPTypes now.
  • Both request and response streaming works.

Result

Transport works with the 0.3.0 runtime API of.

Test Plan

Adapted tests.

@czechboy0 czechboy0 changed the title [WIP] [AHC Transport] Async bodies + swift-http-types adoption [AHC Transport] Async bodies + swift-http-types adoption Sep 18, 2023
@czechboy0 czechboy0 marked this pull request as ready for review September 18, 2023 13:59
Copy link
Copy Markdown
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll hold off approving until we land runtime.

Copy link
Copy Markdown
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dnadoba ?

Copy link
Copy Markdown
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czechboy0 czechboy0 merged commit 0a0c648 into swift-server:main Sep 27, 2023
@czechboy0 czechboy0 deleted the hd-adopt-http-types branch September 27, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate adopting swift-http-types Make request/response bodies an async sequence of bytes

3 participants