Cherry pick GitLab 187: Graceful connection close without sending QUIT command#85
Merged
fabianfett merged 1 commit intoswift-server:mainfrom Aug 4, 2023
Conversation
…T command Cherry pick: https://gitlab.com/swift-server-community/RediStack/-/merge_requests/187 > Note: Clients should not use this command. Instead, clients should simply close the connection when they're not used anymore. Terminating a connection on the client side is preferable, as it eliminates TIME_WAIT lingering sockets on the server side. https://redis.io/commands/quit/
Joannis
approved these changes
Aug 4, 2023
Member
Joannis
left a comment
There was a problem hiding this comment.
LGTM. I don't think reading the docs that older servers are affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick: https://gitlab.com/swift-server-community/RediStack/-/merge_requests/187
Redis connections should not send a QUIT command before closing
From Redis docs