Merged
Conversation
Joannis
reviewed
Jul 3, 2023
| /// - Parameters: | ||
| /// - connectionInitialDatabase: The optional database index to initially connect to. The default is `nil`. | ||
| /// Redis by default opens connections against index `0`, so only set this value if the desired default is not `0`. | ||
| /// Redis by default opens connections against index `0`, so only set this value if the desired default is not `0`. |
Joannis
requested changes
Jul 3, 2023
Member
Joannis
left a comment
There was a problem hiding this comment.
Check the breaking change. The rest looks good
| connectionUsername: String? = nil, | ||
| connectionPassword: String? = nil, | ||
| connectionDefaultLogger: Logger? = nil, | ||
| tcpClient: ClientBootstrap? = nil |
Member
There was a problem hiding this comment.
I think this will break, as we now have two instances of .init() where all arguments are defaulted to nil
| } | ||
| } | ||
|
|
||
| private func send0( |
Joannis
requested changes
Jul 3, 2023
| /// - `defaultLogger`: The optional prototype logger to use as the default logger instance when generating logs from the connection. | ||
| /// If one is not provided, one will be generated. See `RedisLogging.baseConnectionLogger`. | ||
| /// - Throws: `RedisConnection.Configuration.ValidationError` if invalid arguments are provided. | ||
| public init( |
Member
There was a problem hiding this comment.
Actually, isn't this the same scenario? Also two cases where a public init(address: ...) would be ambiguous?
Joannis
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.