Merged
Conversation
Member
|
@fabianfett how do builds get triggered? |
Collaborator
|
@swift-server-bot test this please |
Collaborator
|
@Joannis CI should be triggered automatically once I set them up, or they can be force-triggered using "test this please" comment (e.g., #54 (comment)) |
Member
Author
|
CI fails as expected. Will fix with follow up PR #52. |
yim-lee
approved these changes
Jun 16, 2023
Collaborator
yim-lee
left a comment
There was a problem hiding this comment.
CI jobs are configured. We can add soundness check job etc. later when ready. Just let me know.
Comment on lines
+31
to
+34
| ARG swiftformat_version=0.48.8 | ||
| RUN git clone --branch $swiftformat_version --depth 1 https://github.com/nicklockwood/SwiftFormat $HOME/.tools/swift-format | ||
| RUN cd $HOME/.tools/swift-format && swift build -c release | ||
| RUN ln -s $HOME/.tools/swift-format/.build/release/swiftformat $HOME/.tools/swiftformat |
Collaborator
There was a problem hiding this comment.
Can remove this block if there is no plan to run swiftformat.
Member
Author
There was a problem hiding this comment.
I intend to enable it very soon :)
Joannis
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use the swift-server CI going forward. For this we need to add a bunch of docker magic to work.
Changes
Open ends
Some of the CI jobs will fail. We should enable it and one by one make it green. First one is already posted: #52.