Skip to content

Remove all NIO umbrella imports #59

@fabianfett

Description

@fabianfett

We should not depend on the NIO umbrella module.

Instead we should explicitly

  • import NIOCore
  • import NIOPosix
  • import NIOConcurrencyHelpers
  • import NIOEmbedded
  • ...

where needed.

We should also add explicit dependencies in the Package.swift

Acceptance criteria:

This code in scripts/soundness.sh can be commented in again and CI passes:

# This checks for the umbrella NIO module.
printf "=> Checking for imports of umbrella NIO module... "
if git grep --color=never -i "^[ \t]*import \+NIO[ \t]*$" > /dev/null; then
    printf "\033[0;31mUmbrella imports found.\033[0m\n"
    git grep -i "^[ \t]*import \+NIO[ \t]*$"
    exit 1
fi
printf "\033[0;32mokay.\033[0m\n"

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions