[C/C++] CMake: Set include install interface to include#1535
Merged
martin4861 merged 2 commits intoswift-nav:masterfrom Nov 14, 2025
Merged
Conversation
|
One thing to point out: The headers are installed to Lines 81 to 83 in 0a93888 |
martin4861
reviewed
Nov 14, 2025
| @@ -53,7 +53,7 @@ target_include_directories(sbp | |||
| PUBLIC | |||
| $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include> | |||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}> | |||
Contributor
There was a problem hiding this comment.
I am wondering whether this line is still needed?
Contributor
Author
There was a problem hiding this comment.
I don't see any reason you would need it. But I didn't want to break any of your existing tooling/setups that might depend on it in an unexpected way.
martin4861
reviewed
Nov 14, 2025
| $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include> | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}> | ||
| $<INSTALL_INTERFACE:${CMAKE_INSTALL_LIBDIR}> | ||
| $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}> |
martin4861
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
Resolves #1532.
API compatibility
Does this change introduce a API compatibility risk?
No, the API is unchanged. It does introduce a build compatibility risk depending on how consumers use the configured install interface.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
The change should be documented in the release notes with instructions that consumers will need to reconfigure their existing build caches.
JIRA Reference
N/A