Merged
Conversation
2a8c159 to
c4ede65
Compare
Contributor
Author
|
…ut clang Readd hedron Fix local_includes Add notes about MODULE file
9292b88 to
86a913b
Compare
|
armallen
reviewed
Jul 28, 2025
Contributor
armallen
left a comment
There was a problem hiding this comment.
LGTM overall, I only wonder why we need the .bazelignore change?
woodfell
reviewed
Jul 28, 2025
woodfell
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
Implement a Bazel 7 compatible
MODULEfile.Uses swift-nav/rules_swiftnav#167
The
MODULEfile is sufficient to consumelibsbp. However, buildinglibsbpusing theMODULEis not yet supported on all platforms (e.g. darwin aarch64 is not yet working). The local development in this repo is still on Bazel 6/WORKSPACE, therefore nothing changes.Needed
rules_swiftnavchanges: swift-nav/rules_swiftnav#167API compatibility
Does this change introduce a API compatibility risk?
No!
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
Not needed.
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-4083