Update deprecated windows build image#1483
Merged
Conversation
|
RReichert
approved these changes
Jul 9, 2025
martin4861
approved these changes
Jul 9, 2025
| name: "Windows 2019 (Generator: ${{ matrix.generator }}, Shared Library: ${{ matrix.build_shared_libraries }})" | ||
| runs-on: windows-2019 | ||
| name: "Windows Latest (Generator: ${{ matrix.generator }}, Shared Library: ${{ matrix.build_shared_libraries }})" | ||
| runs-on: windows-latest |
Contributor
There was a problem hiding this comment.
Is there only windows-latest, or maybe something like windows-2025, which could give us some kind of reproducibility?
Contributor
Author
There was a problem hiding this comment.
There is both windows-2022 and windows-2025.
I thought: Specifying the version will 100% lead to build failures in the future, when the version gets deprecated again.
Using latest might give us a chance (maybe 10%?) that things keep on going smoothly without maintenance for quite a while.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
API compatibility
Does this change introduce a API compatibility risk?
NO
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX