Auto submodule update: cmake - Update protobuf to v25.1 (#183)#1476
Merged
Auto submodule update: cmake - Update protobuf to v25.1 (#183)#1476
Conversation
# Changes Since we are upgrading the protobuf version, the location for the root CMakeLists.txt has changed, hence the update. We also updated the swift targets (ex: `swift_add_library` or `swift_add_executable`) so that we can now set a global default C++ version with `SWIFT_CXX_STANDARD`. Lastly tried to unify the interface between `swift_add_test` and the rest of the other swift targets since `swift_add_test` was developed separately to the rest, hence the difference in interface. These changes will allow us to set the C++ for our Swift targets independently from the third party libraries. Triggered-By: cmake 361035b6c59305fe1602f4297bc357c8f2caa05f Upstream-PR: http://github.com/swift-nav/cmake/pull/183
|
RReichert
approved these changes
May 19, 2025
sbmueller
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR by Jenkins. If CI has passed successfully, merge away!
cmake 8920f2a3 -> 361035b6
This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/20021/.