Skip to content

Fix actions/checkout@v2#1472

Merged
RReichert merged 11 commits intomasterfrom
rodrigor/fix-checkout
Feb 10, 2025
Merged

Fix actions/checkout@v2#1472
RReichert merged 11 commits intomasterfrom
rodrigor/fix-checkout

Conversation

@RReichert
Copy link
Copy Markdown
Contributor

@RReichert RReichert commented Feb 7, 2025

Changes

Using actions/checkout@v2 to checkout the github code onto your local workspace is nice, but can be problematic when using old docker image. From what I understand, the action uses NodeJS version internally and therefore requires a modern glibc version as the action can impose newer NodeJS version and therefore can eventually break our build.

To avoid this, I'm just going to manually checkout the code and run the submodule update manually. This will fix our C builds.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 8, 2025

@RReichert RReichert marked this pull request as ready for review February 8, 2025 12:41
@RReichert RReichert requested a review from a team as a code owner February 8, 2025 12:41
@RReichert RReichert merged commit 5bb6d5a into master Feb 10, 2025
@RReichert RReichert deleted the rodrigor/fix-checkout branch February 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants