Skip to content

Add compensated IMU message [AP-1475]#1446

Merged
ismolyakov merged 9 commits intomasterfrom
ivan/comp-imu-draft-5
Oct 3, 2024
Merged

Add compensated IMU message [AP-1475]#1446
ismolyakov merged 9 commits intomasterfrom
ivan/comp-imu-draft-5

Conversation

@ismolyakov
Copy link
Copy Markdown
Contributor

@ismolyakov ismolyakov commented Oct 1, 2024 •
edited
Loading

Description

Adding a new MSG_IMU_COMP according to the corresponding design doc.

Screenshot 2024-10-01 at 8 57 33 PM

API compatibility

No, this is a new message

API compatibility plan

n/a

JIRA Reference

https://swift-nav.atlassian.net/browse/AP-1475

@ismolyakov ismolyakov requested review from a team, notoriaga and pcrumley as code owners October 1, 2024 23:35
@ismolyakov ismolyakov changed the title Comp imu [draft 5] Add compensated IMU message Oct 2, 2024
@ismolyakov ismolyakov requested a review from junc52 October 2, 2024 01:00
junc52
junc52 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Copy Markdown

@junc52 junc52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving challenging work!
Question : so updating imu.yaml will produce all these changes automatically?

@ismolyakov ismolyakov removed the draft label Oct 2, 2024
@ismolyakov ismolyakov changed the title Add compensated IMU message Add compensated IMU message [AP-1475] Oct 2, 2024
@ismolyakov
Copy link
Copy Markdown
Contributor Author

ismolyakov commented Oct 2, 2024

Thanks for resolving challenging work! Question : so updating imu.yaml will produce all these changes automatically?

Yes! the intended process is:

  • define the message specs
  • run make all and all code should be generated (this is not what I encountered: while the scripts of a given Docker image on a given machine may succeed, the pipeline items may fail - I am still in progress to identify the best recipe that leads to passing pipeline)

pcrumley
pcrumley requested changes Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the link to the internal confluence documentation from you PR description?

I'm also curious about this statement: "This PR doesn't include a corresponding unit test due to test generation problems. It is proposed to merge as is to unblock development and address test generation as the next step." Do you need help/advice on how to do the unit test or are you struggling to generate the input data for the messages?

Finally, can you close all the draft PRs?
#1441
#1442
#1443
#1444
#1445

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ismolyakov ismolyakov merged commit d775e3d into master Oct 3, 2024
@ismolyakov ismolyakov deleted the ivan/comp-imu-draft-5 branch October 3, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrumley pcrumley pcrumley approved these changes

@notoriaga notoriaga Awaiting requested review from notoriaga notoriaga is a code owner

@sokhealy sokhealy Awaiting requested review from sokhealy

+1 more reviewer

@junc52 junc52 junc52 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

New Message

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ismolyakov @junc52 @pcrumley @RReichert