Reference only the runner name [OI-1830]#1416
Merged
fpezzinosn merged 2 commits intomasterfrom Jul 9, 2024
Merged
Conversation
fpezzinosn
commented
Jul 9, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM rust:1.65-slim-buster | |||
| FROM rust:1.67.1-slim-buster | |||
Contributor
Author
There was a problem hiding this comment.
Updated due to
error: package `cc v1.1.0` cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.67 or newer, or use
cargo update -p cc@1.1.0 --precise ver
where `ver` is the latest version of `cc` supporting rustc 1.65.0
Error: Process completed with exit code 101.
in https://github.com/swift-nav/libsbp/actions/runs/9861796299/job/27231017078?pr=1416
Contributor
There was a problem hiding this comment.
hm maybe just bump to 1.75?
|
ljbade
approved these changes
Jul 9, 2024
pcrumley
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
The Benchamarks Action has been failing since June 18th.
The last successful run of Benchmarks contains the following warning
Later runs start showing that no runners are picking up the job.
In this PR I'm changing the use of labels and instead only using the runner name. I have obtained that info from here.
API compatibility
Does this change introduce a API compatibility risk?
No, it only updates a github workflow file
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/OI-1830