link PNGs instead of SVGs (closes #270 and #271) #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you remove the changes to the HTML files in this PR? Right now there's a ton of noise for a small change in the markdown files. Let me know if you want help with this! |
Contributor
|
Hm - we generally prefer SVG to Markdown because SVG rescales better on
small screens, but on the other hand, if the fonts aren't rendering...
|
baef22d to
9a3d8fc
Compare
Contributor
Author
Contributor
No problem :) I'm 👍 on this PR but will wait for at least one other 👍 before merging (@gvwilson?) |
Contributor
|
Go ahead - we'll figure it out.
|
Contributor
Author
|
BTW An alternative solution would be to replace text by paths. This way we keep SVG format, but we loose the possibility to edit texts. |
Contributor
|
Thanks @btel! PS: I'm a big fan of svg_utils, used it for a lot of figures :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It replaces links to SVG files with links with respective PNGs. This solves the problem with differences of rendering of SVGs on different platforms and browsers (mainly related to fonts - see #270 and #271).