fix(es/compat): Revert redundant hoister visits in getter/setter props

github-actions[bot] · kdy1 · github-actions[bot] · commit cfb6d873124d · 2026-01-07T03:45:48.000Z
This commit reverts the changes to visit_mut_getter_prop and visit_mut_setter_prop that were introduced in commit 2bf316a. These changes introduced redundant visits to the hoister, which is incorrect. Unlike arrow functions which need special handling, getters and setters already create new hoister scopes via `old_rep = self.hoister.take()`, so the additional hoister visit before the main visit is unnecessary and incorrect. Changes: - Reverted visit_mut_getter_prop to original implementation - Reverted visit_mut_setter_prop to original implementation - Reverted getter-setter/output.js test snapshot to original The original fix for issue #11422 (arrow function this context) remains intact. Co-authored-by: Donny/강동윤 <kdy1@users.noreply.github.com>
diff --git a/crates/swc_ecma_compat_es2015/src/arrow.rs b/crates/swc_ecma_compat_es2015/src/arrow.rs
@@ -198,11 +198,6 @@ impl VisitMut for Arrow {
         if let Some(body) = &mut f.body {
             let old_rep = self.hoister.take();
 
-            // First, replace `this` with `_this` in the body
-            // This must happen before converting nested arrow functions
-            body.visit_mut_with(&mut self.hoister);
-
-            // Then, convert nested arrow functions
             body.visit_mut_with(self);
 
             let decl = mem::replace(&mut self.hoister, old_rep).to_stmt();
@@ -240,11 +235,6 @@ impl VisitMut for Arrow {
         if let Some(body) = &mut f.body {
             let old_rep = self.hoister.take();
 
-            // First, replace `this` with `_this` in the body
-            // This must happen before converting nested arrow functions
-            body.visit_mut_with(&mut self.hoister);
-
-            // Then, convert nested arrow functions
             body.visit_mut_with(self);
 
             let decl = mem::replace(&mut self.hoister, old_rep).to_stmt();
diff --git a/crates/swc_ecma_transforms_compat/tests/arrow/getter-setter/output.js b/crates/swc_ecma_transforms_compat/tests/arrow/getter-setter/output.js
@@ -2,19 +2,16 @@ var _this = this;
 const a1 = function() {
     return {
         get this () {
-            var _this1 = this, _arguments = arguments;
-            _this1;
-            _arguments;
+            this;
+            arguments;
         },
         set arguments (a = this){
-            var _this2 = this, _arguments1 = arguments;
-            _this2;
-            _arguments1;
+            this;
+            arguments;
         },
         get [_this] () {
-            var _this3 = this, _arguments2 = arguments;
-            _this3;
-            _arguments2;
+            this;
+            arguments;
         }
     };
 };
