Add test cases for styled-jsx with nested CSS and variables#443
Closed
vpontis wants to merge 3 commits intoswc-project:mainfrom
Closed
Add test cases for styled-jsx with nested CSS and variables#443vpontis wants to merge 3 commits intoswc-project:mainfrom
vpontis wants to merge 3 commits intoswc-project:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kdy1 I looked thru our codebase and tried to find examples of tests that should cover most of how we use Styled JSX.
I'm not able to get all of the test passing when I run
cargo test --package styled_jsxbecause I get errors like this where the ID generated is different. I get this issue onmain- so maybe there is some kind of Rust version issue?