Open
Conversation
The header is not installed by wlroots when the DRM backend is disabled. We don't need it here, so don't include it. Closes: swaywm#7943 (cherry picked from commit ca40663)
Co-authored-by: Ian Fan <ianfan0@gmail.com> Co-authored-by: Nathan Schulte <nmschulte@gmail.com> Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
- Rebased against master - Made sure only the tray dbus menu patches are in
Co-authored-by: Demi Marie Obenour <demiobenour@gmail.com>
|
This'd be neat to get merged, it'd be so cool to be able to easily switch wifi networks using mm-applet. :D |
|
I've been using this (in its various iterations) for years now. |
Neat! Then it seems to work. Have the sway devs ever said anything about this MR and/or the predecessors..? Wondering why not much seems to have happened over the years, even though the patch does not even seem that big. |
|
This might be useful here: I'm currently working on a new widget library and as an example I implemented a swaybar with full tray dbusmenu support: https://github.com/pd2s/sw/tree/master/examples/sw_swaybar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a rebase, along the lines of existing PRs (#6249, #8405)
I rebased #8405, then cherry-picked a PR grazzolini#1 from @grazzolini's own fork.
I tested locally and it seems to be working fine, at least with nm-applet and keepassxc.
Disclaimer: this is just a rebase, I know nothing about C so I won't be able to progress much further than this unfortunately.