Parse url path to extract query parameters from filename when calling embed.FS#103
Merged
ubogdan merged 2 commits intoswaggo:masterfrom Aug 26, 2023
Merged
Conversation
Contributor
Author
|
Hi @ubogdan, sorry to ping you directly. This bug block most oauth logic in swaggerui. If you don't have time please ignore this message. |
ubogdan
approved these changes
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that
oauth-redirect.htmlis broken in latest version since it return 404 not found when query parameters are present (which are to be expected during an oauth process)I think it was introduced in #100
This simply fix the issue by parsing the relative path with
url.Parsebefore sending it to embed.FS.I added a test similar to what is to be expected from an oauth process.
The same test previously passed successfully on v2.0.0.