Skip to content

Make logo exchange via plugin api possible#7521

Merged
tim-lai merged 3 commits intoswagger-api:masterfrom
mathis-m:featurelogo-component
Jul 18, 2022
Merged

Make logo exchange via plugin api possible#7521
tim-lai merged 3 commits intoswagger-api:masterfrom
mathis-m:featurelogo-component

Conversation

@mathis-m
Copy link
Copy Markdown
Contributor

Description

  1. Refactored logo into component.
  2. Added docs

Motivation and Context

Fixes #7494

How Has This Been Tested?

  • browser
  • probably existing tests

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 878e848 into swagger-api:master Jul 18, 2022
@tim-lai
Copy link
Copy Markdown
Contributor

tim-lai commented Jul 18, 2022

@mathis-m PR merged! I know it's been awhile, but thanks again for the contribution!. 😄

@mathis-m
Copy link
Copy Markdown
Contributor Author

@tim-lai oh wow that's cool. :)

@mathis-m mathis-m deleted the featurelogo-component branch July 18, 2022 21:03
@uvulpos
Copy link
Copy Markdown

uvulpos commented Jul 3, 2024

nice feature but is it possible to replace it also in bundled option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base64 packing the logo is unproductive and prohibitively complicated

3 participants