[Java][Jersey2] Make generated client code thread safe#7605
Merged
wing328 merged 2 commits intoswagger-api:masterfrom Feb 18, 2018
Merged
[Java][Jersey2] Make generated client code thread safe#7605wing328 merged 2 commits intoswagger-api:masterfrom
wing328 merged 2 commits intoswagger-api:masterfrom
Conversation
… the withHttpInfo pattern used by many other generated clients
… the withHttpInfo pattern used by many other generated clients
Contributor
|
@tsiq-karold thanks for the PR. Sorry for the delay in merging this PR into master due to Chinese New Year celebration. @jeff9finger thanks for reviewing the change. |
Contributor
Upgrade NoteThe following properties have been removed from To obtain the status code and HTTP headers, please use the additional |
This was referenced Mar 1, 2019
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR is to make the generated Jersey 2 client thread safe. Currently, the only way to get to response headers and status is by inspecting some fields on the ApiClient which is not thread safe. This PR changes the generated code to follow a similar pattern used by other generated clients with "withHttpInfo" flavours of each method. It is backwards compatibility breaking as it removes the existing header and status fields.
Fixes #7453
cc @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger