feat(ls): validation resolve local reference#5113
Merged
lukaszzazulak merged 7 commits intomainfrom Feb 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a validation gap where $ref parameters in path/operation parameter lists could cause the path-template/parameter matching rule to incorrectly pass without verifying that referenced parameters are actually defined.
Changes:
- Resolves local (
#/...)$refParameter Objects during path template validation so referencedin: path+nameare counted. - Updates validation tests to expect additional diagnostics when referenced path parameters don’t actually match the path template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/apidom-ls/src/services/validation/linter-functions.ts | Adds local $ref resolution for parameter elements before building the set of path parameters used for template matching. |
| packages/apidom-ls/test/validate.ts | Extends expected diagnostics to cover cases where $ref parameters previously masked missing required path params. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Looks good; but should be verified with a test 🧪 |
robert-hebel-sb
approved these changes
Feb 11, 2026
glowcloud
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a validation gap where the presence of a path parameter reference caused the validator to incorrectly mark the document as valid without verifying that all required parameters were actually defined.