fix(javascript): upgrade uuid to ^14.0.0 and TypeScript to ^5.0#2285
Closed
th3nolo wants to merge 1 commit into
Closed
fix(javascript): upgrade uuid to ^14.0.0 and TypeScript to ^5.0#2285th3nolo wants to merge 1 commit into
th3nolo wants to merge 1 commit into
Conversation
uuid <14.0.0 has a buffer bounds check vulnerability (GHSA-w5hq-g745-h8pq, CWE-122). uuid@14 type declarations use 'export type *' syntax (TS1383) which requires TypeScript 5.0+, so both are upgraded together. Changes: - uuid: ^10.0.0 -> ^14.0.0 (security fix) - typescript: ^4.0 -> ^5.0 (required for uuid@14 type compatibility) Verified: tsc build passes, all 44 tests pass (1 skipped, 0 fail).
Member
|
Thanks for the PR! I think we'll end up merging #2286 instead though. |
Member
|
Decided to merge #2286 instead. Thanks again though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
uuid@14fixes GHSA-w5hq-g745-h8pq (CWE-122, buffer bounds check in uuid v3/v5/v6). The existing Dependabot PR #2284 bumped uuid but CI failed with:uuid@14's type declarations useexport type *syntax which requires TypeScript 5.0+.Solution
Bump
uuidfrom^10.0.0to^14.0.0andtypescriptfrom^4.0to^5.0together. svix only usesuuid.v4()(idempotency keys inrequest.ts), no v3/v5/v6 usage, so no API risk.npm installcompletes without errorsnpm run buildpassesnpm testpasses (44 pass, 1 skipped, 0 fail)npm auditshows 0 critical vulnerabilities for uuid