Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where Svelte 5 components lose dependency information for imports used exclusively in template markup (outside <script> sections). The issue occurred because TypeScript preprocessing removed "unused" imports before the Svelte compiler could analyze the template.
Changes:
- Modified
svelte-wrap.mjsto skip TypeScript preprocessing for Svelte 5+, leveraging its native TypeScript support - Updated test expectations to verify that component imports are now properly preserved in the transpiled output
- Added version detection logic to conditionally apply preprocessing only for Svelte 4 and earlier
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/extract/transpile/svelte-wrap.mjs |
Added major version detection and conditional preprocessing logic to skip TypeScript transpilation for Svelte 5+, which has native TypeScript support |
test/extract/transpile/svelte-wrap.spec.mjs |
Removed test transformation that was stripping the Header import, as it should now be preserved |
test/extract/transpile/__fixtures__/svelte.js |
Added the expected Header import to the fixture to reflect correct dependency detection |
…utside <script> sections
153cef6 to
4a1c36b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
addresses #1045
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️