Skip to content

fix broken CI tests#115

Merged
svenevs merged 5 commits intomasterfrom
fix/pimpl_tests
Oct 3, 2021
Merged

fix broken CI tests#115
svenevs merged 5 commits intomasterfrom
fix/pimpl_tests

Conversation

@svenevs
Copy link
Copy Markdown
Owner

@svenevs svenevs commented Oct 1, 2021

  • fix class_like reparenting to namespaces.

    • See tox -e py -- -k cpp_pimpl before this, somehow something changed and class_like were not getting reparented to namespaces. It is not clear how only this test was broken...

        Expected class hierarchy:
        --------------------------------------------
        - :ref:`namespace_pimpl`
            - :ref:`namespace_pimpl__detail`
                - :ref:`exhale_class_classpimpl_1_1detail_1_1EarthImpl`
                - :ref:`exhale_class_classpimpl_1_1detail_1_1JupiterImpl`
            - :ref:`exhale_class_classpimpl_1_1Earth`
            - :ref:`exhale_class_classpimpl_1_1Earth__v2`
            - :ref:`exhale_class_classpimpl_1_1EarthImpl`
            - :ref:`exhale_class_classpimpl_1_1Jupiter`
            - :ref:`exhale_class_classpimpl_1_1Jupiter__v2`
            - :ref:`exhale_class_classpimpl_1_1JupiterImpl`
            - :ref:`exhale_class_classpimpl_1_1Planet`
        Generated class hierarchy:
        --------------------------------------------
        - :ref:`namespace_pimpl`
            - :ref:`exhale_class_classpimpl_1_1Earth`
            - :ref:`exhale_class_classpimpl_1_1Earth__v2`
            - :ref:`exhale_class_classpimpl_1_1Jupiter`
            - :ref:`exhale_class_classpimpl_1_1Jupiter__v2`
            - :ref:`exhale_class_classpimpl_1_1Planet`
        - :ref:`exhale_class_classpimpl_1_1detail_1_1EarthImpl`
        - :ref:`exhale_class_classpimpl_1_1detail_1_1JupiterImpl`
        - :ref:`exhale_class_classpimpl_1_1EarthImpl`
        - :ref:`exhale_class_classpimpl_1_1JupiterImpl`
      
  • Fix warnings on CMP0079 (cxx tests, require CMake 3.13+).

  • Correct download of Catch2 file(DOWNLOAD [url]).

  • Remove AppVeyor and Travis builds.

  • Add GitHub Actions builds.

  • Fix linkcheck errors.

  • Figure out what's going on with the coverage changes.

@svenevs svenevs closed this Oct 1, 2021
@svenevs svenevs reopened this Oct 1, 2021
@svenevs svenevs changed the title fix class_like reparenting to namespaces fix broken CI tests Oct 1, 2021
@svenevs svenevs force-pushed the fix/pimpl_tests branch 8 times, most recently from e26ccdd to df24338 Compare October 1, 2021 11:40
@svenevs svenevs closed this Oct 1, 2021
@svenevs svenevs reopened this Oct 1, 2021
@svenevs svenevs force-pushed the fix/pimpl_tests branch 13 times, most recently from 4a26979 to d31fbce Compare October 3, 2021 09:24
@svenevs svenevs force-pushed the fix/pimpl_tests branch 3 times, most recently from a12d2a1 to 36e512c Compare October 3, 2021 10:45
@svenevs svenevs force-pushed the fix/pimpl_tests branch 2 times, most recently from 273eae2 to 74196d3 Compare October 3, 2021 12:27
@svenevs svenevs merged commit 9c581c9 into master Oct 3, 2021
@svenevs svenevs deleted the fix/pimpl_tests branch October 3, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant