chore: minor tidy-ups#18326
Conversation
|
| create_effect(RENDER_EFFECT, () => { | ||
| fn(...values.map(get)) | ||
| }); |
There was a problem hiding this comment.
I very often find myself adding console logs to this function, or otherwise engaging in debugging shenanigans, and the implicit return gets in the way
| } | ||
|
|
||
| set_signal_status(effect, DESTROYING); | ||
| effect.f |= DESTROYING; |
There was a problem hiding this comment.
set_signal_status should only ever be called with CLEAN/DIRTY/MAYBE_DIRTY. The current line only works by accident
|
baseballyama
left a comment
There was a problem hiding this comment.
I’ve reviewed the changes carefully, and it looks good to me.
some more stuff extracted from #18035