fix: support using keyword#16190
Closed
Rich-Harris wants to merge 3 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 0fd3921 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
6 tasks
Member
Author
|
Realised that we don't need to do the whole async dance to get top-level |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to the latest version of Acorn, and replaces
ecmaVersion: 16with'latest'which allows Svelte code to use theusingkeyword (which is now stage 4, i.e. part of the language).I didn't think it worthwhile to add a test (would be like having a test for
vardeclarations or whatever) but you can easily see it working in the playground once it deploys.One thing we could conceivably do is transform components with top-level
usingsuch that disposals don't occur until the component is removed. This would mean wrapping everything in an async function that ends with something like this:Personally I'm not sold on the idea — it's a little magical, and would prevent the component from exporting values — but I raise it as a possibility for discussion. If we thought we might want to add that capability in future we could always prevent the usage of top-level
using, though that itself might be annoying.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint