fix: robustify interop of exports and props#11064
Merged
Merged
Conversation
- don't throw a dev time error when binding to an export (fixes #11008) - remove bindings that are for component exports - throw an error when using a component export with the same name as a property
🦋 Changeset detectedLatest commit: a36973d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Apr 4, 2024
| "svelte": patch | ||
| --- | ||
|
|
||
| fix: robustify interop of exports and props |
Member
There was a problem hiding this comment.
should this be considered a breaking change?
Suggested change
| fix: robustify interop of exports and props | |
| breaking: robustify interop of exports and props |
Member
Author
There was a problem hiding this comment.
Mhm true - in runes mode at least this is a breaking change, so I should also note that in the docs
Rich-Harris
approved these changes
Apr 4, 2024
Rich-Harris
left a comment
Member
There was a problem hiding this comment.
LGTM aside from the question about the changeset
Contributor
|
There appears to be some TS issues with the docs that is causing the CI to fail on the svelte-5-preview build. |
…elte into exports-and-bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint