fix: Preserve event attribute casing in svelte 5#2347
Merged
dummdidumm merged 2 commits intoApr 25, 2024
Conversation
dummdidumm
approved these changes
Apr 25, 2024
dummdidumm
left a comment
Member
There was a problem hiding this comment.
Not checking a list of events is the right approach as this applies to any event. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2345
When running svelte 5+ any attributes beginning with "on*" after left in their original casing.
may be better to check the knownevents.ts list, but not sure its ideal to maintain the event list in multiple places in addition to the performance of searching the array for each attribute.