Skip to content

add dark mode styles to default error page#9460

Merged
Rich-Harris merged 1 commit intomasterfrom
error-page-dark-mode
Mar 20, 2023
Merged

add dark mode styles to default error page#9460
Rich-Harris merged 1 commit intomasterfrom
error-page-dark-mode

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

closes sveltejs/learn.svelte.dev#261.

current error page, whether light or dark mode:

image

new error page with dark mode:

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: 8cab7d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 1b1e8e3 into master Mar 20, 2023
@Rich-Harris Rich-Harris deleted the error-page-dark-mode branch March 20, 2023 18:10
@github-actions github-actions bot mentioned this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iframe flashes white between exercises in dark mode

2 participants