Skip to content

feat: expose submitter to use:enhance SubmitFunction#9425

Merged
dummdidumm merged 1 commit intosveltejs:masterfrom
msonnb:use-enhance-submitter
Mar 15, 2023
Merged

feat: expose submitter to use:enhance SubmitFunction#9425
dummdidumm merged 1 commit intosveltejs:masterfrom
msonnb:use-enhance-submitter

Conversation

@msonnb
Copy link
Copy Markdown
Contributor

@msonnb msonnb commented Mar 15, 2023

closes #9414

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@msonnb msonnb changed the title Expose submitter to use:enhance SubmitFunction feat: expose submitter to use:enhance SubmitFunction Mar 15, 2023
dummdidumm
dummdidumm approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit d257d37 into sveltejs:master Mar 15, 2023
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Merged
@msonnb msonnb deleted the use-enhance-submitter branch March 15, 2023 13:38
This was referenced Mar 22, 2023
Merged
Closed
@igneosaur
Copy link
Copy Markdown
Contributor

igneosaur commented Mar 22, 2023 •
edited
Loading

Hi you two, you might have seen I've opened up an issue and a PR that references this PR. It looks like the SubmitFunction type is duplicated in index.d.ts (due to some TS bug it seems) which is the type that is accessed from any submit function declaration inside a SvelteKit app (rather than the enhance prop on a form). This new PR just adds the submitter argument to this additional type.

Thanks for this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose submitter to use:enhance SubmitFunction parameter

3 participants

@msonnb @igneosaur @dummdidumm