fix: correct undefined reference to global var with Vitest#9252
Merged
Rich-Harris merged 1 commit intomasterfrom Mar 1, 2023
Merged
fix: correct undefined reference to global var with Vitest#9252Rich-Harris merged 1 commit intomasterfrom
Rich-Harris merged 1 commit intomasterfrom
Conversation
Member
|
Is there a way we can create this global when Vitest is running, rather than adding code to the bundle for everyone else? |
Member
Author
|
We could probably change it to the code below, but it seems like it'd only save a byte or two after compression, so I don't know if it's even worth adding that complication? |
Rich-Harris
approved these changes
Mar 1, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9162
We should really add tests for this...