Skip to content

Defer client hooks import to allow using env in them#8803

Closed
gtm-nayan wants to merge 3 commits intomasterfrom
defer-client-hooks-import
Closed

Defer client hooks import to allow using env in them#8803
gtm-nayan wants to merge 3 commits intomasterfrom
defer-client-hooks-import

Conversation

@gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Jan 31, 2023

ref #8464

Need some insight on this commit, without it, all the tests start failing at random because it can't find the selector that's set on hydration, no matter what the timeout is. Although it seems like the wrong location to put it in.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023

⚠️ No Changeset found

Latest commit: 0e1ab81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

dummdidumm commented Jan 31, 2023

It's weird indeed that this makes things fail, don't have a good idea why just from looking at it - before this change, it was loaded even earlier (eagerly inside client.js).

@dominikg you had ideas about some init hook that blocks starting the client until for example the language is determined. Would the timing of "create and init client -> run hooks -> hydrate and start router" be wrong for this use case?

@Rich-Harris Rich-Harris mentioned this pull request Feb 8, 2023
Merged
5 tasks
@Rich-Harris
Copy link
Member

Rich-Harris commented Feb 16, 2023

going to close this in favour of #8957, which is finally inching towards being shippable, after a detour that involved learning more than i ever thought i'd need to know about the behaviour of preload and modulepreload links

@benmccann benmccann deleted the defer-client-hooks-import branch February 13, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gtm-nayan @dummdidumm @Rich-Harris