Skip to content

[chore] don't override printUrls#7724

Merged
Rich-Harris merged 2 commits intosveltejs:masterfrom
benmccann:deferred_warning
Nov 19, 2022
Merged

[chore] don't override printUrls#7724
Rich-Harris merged 2 commits intosveltejs:masterfrom
benmccann:deferred_warning

Conversation

@benmccann
Copy link
Member

See vitejs/vite#9378 (comment) for an explanation

Should this close vitejs/vite#9378?

@benmccann benmccann added the vite label Nov 19, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2022

🦋 Changeset detected

Latest commit: 9181f96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Should this close vitejs/vite#9378?

No. The current behaviour still makes no sense. Many things could log info/warnings/errors, and not all of them have access to config.logger. Nor does it make sense that we have to store deferred_warning until configResolved just so that we're able to use config.logger.

However, this new information is useful:

It seems Vite already does this as long as config.logger.warn/warnOnce/error is used.

All we need to do, it seems, is add a config.logger.warn('') inside configResolved, and we will effectively trick Vite into not nuking logs. Updating the PR.

@benmccann
Copy link
Member Author

the changes lgtm

@Rich-Harris Rich-Harris merged commit 580d733 into sveltejs:master Nov 19, 2022
@benmccann benmccann deleted the deferred_warning branch November 19, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clearScreen: 'update'

2 participants