Conversation
🦋 Changeset detectedLatest commit: 8c12306 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
left a comment
There was a problem hiding this comment.
I think we also need a "how to migrate" section in the PR description so people know what to do
i think in this case the how to migrate is self explanatory, just update the required peer dependencies, there is no code change or config change needed as far as i am aware |
|
Oh, that's a pleasant surprise, nice! |
Rich-Harris
left a comment
There was a problem hiding this comment.
i think this broke paths.assets handling. investigating
|
I'm probably stupid, but I went into package.json and set And then |
|
I haven't seen that. Can you share a project that reproduces the issue? |
|
Just tried to recreate the issue in StackBlitz but it seems to work fine, so guessing it's something specific to this (private) repo. I tried renaming I don't really know where to even start debugging the issue since I don't know a lot about NPM's inner workings. I could use |
That sounds like you still have Vite 3 in a Another thing you could try is |
|
That fixed it. Really appreciate the help - realise you're not tech support! Not sure what was wrong with my setup 😅 |
Shouldn't affect SvelteKit or its users much other than bumping a version. One nice change is that it fixes the value of
NODE_ENVto be more inline with what one would expect, which I think should help us clean some stuff upTo migrate, simply bump your Vite and SvelteKit versions to the latest versions. See the full Vite 4 migration guide and announcement for more details