[feat] allow +server.js files next to +page files#6773
Merged
Rich-Harris merged 10 commits intomasterfrom Sep 19, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: c29b546 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Sep 13, 2022
Rich-Harris
reviewed
Sep 14, 2022
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
dummdidumm
commented
Sep 15, 2022
dummdidumm
commented
Sep 15, 2022
| @@ -195,7 +195,7 @@ export interface RequestOptions { | |||
|
|
|||
| export interface RouteDefinition { | |||
Member
Author
There was a problem hiding this comment.
aside: it's strange to me that this is private API - it's public because it's part of the public builder methods
…into server-next-to-page
Rich-Harris
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5896
Also added a related paragraph to "Form Actions" because I saw some people asking about this specifically.
Marking as draft because I don't know what to make of this TODO:
kit/packages/kit/src/core/adapt/builder.js
Line 49 in 55493cb
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0