Conversation
Fixed sveltejs#5193 Formatted using `pnpm format`
|
|
Thank you! I'd like to hold off on merging this until we decided what to do with the form proposal, which likely changes what's allowed inside |
benmccann
left a comment
There was a problem hiding this comment.
Your new test seems to be failing:
@sveltejs/kit:test: 1 failed
@sveltejs/kit:test: [chromium-dev-no-js] › test/server.test.js:52:2 › Endpoints › OPTIONS request ==================
|
Nice work so far. As this seems to be your first contribution, I'd like to give a small pointer on the use of the PR template: those |
|
@amunim this PR would need to be rebased and the failing tests would need to be fixed |
|
I am so confused at this point, I have literally searched the whole project and replaced all 204s with 555, 553, and 554 respectively but am still getting 204 as result in my tests. |
|
I'll rebase and work on another issue for now... |
Fixed #5193
Formatted using
pnpm formatpnpm testand lint the project withpnpm lintandpnpm checkpnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0